Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuned Phi3 built with the model builder give gibberish ouput due to lack of support for LoRA #399

Closed
Pathos0925 opened this issue May 4, 2024 · 4 comments
Assignees

Comments

@Pathos0925
Copy link

Has the model builder been proven to work with fine-tuned Phi3 models as suggested in the link in the HF card?
https://huggingface.co/microsoft/Phi-3-mini-4k-instruct/resolve/main/sample_finetune.py

If it has then I am probably doing something wrong in the finetuning.

@natke
Copy link
Contributor

natke commented May 7, 2024

Hi @Pathos0925, can you please share the model builder command and they command you are running and any errors that you get?

@kunal-vaishnavi
Copy link
Contributor

The sample finetuning script appears to be using LoRA, which changes how the resulting ONNX model looks and runs. LoRA is not currently supported in the model builder but support for LoRA will be coming soon. A preview of how the APIs will look for running models with LoRA/QLoRA can be found here.

@Pathos0925
Copy link
Author

The sample finetuning script appears to be using LoRA, which changes how the resulting ONNX model looks and runs. LoRA is not currently supported in the model builder but support for LoRA will be coming soon. A preview of how the APIs will look for running models with LoRA/QLoRA can be found here.

Alright, thank you!

@natke natke changed the title Finetuned Phi3 built with the model builder give gibberish ouput Finetuned Phi3 built with the model builder give gibberish ouput due to lack of support for LoRA May 8, 2024
@natke
Copy link
Contributor

natke commented May 8, 2024

Closing this issue for now. Please check back for LoRA support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants