Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AdvancedLogger Is Not Reentrant Safe in the Init PAth #514

Closed
1 task done
os-d opened this issue Jul 9, 2024 · 2 comments
Closed
1 task done

[Bug]: AdvancedLogger Is Not Reentrant Safe in the Init PAth #514

os-d opened this issue Jul 9, 2024 · 2 comments
Assignees
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@os-d
Copy link
Contributor

os-d commented Jul 9, 2024

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

If a debug print occurs in advanced logger's init path, it will enter an infinite loop.

Expected Behavior

We should be a bit more "advanced." After permanent memory is installed is when this is an issue, we can use a module global to check if we are already in AdvLogger at that point.

Steps To Reproduce

Hit a debug statement in adv logger init path.

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:
All.

Version Information

top of tree.

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@os-d os-d added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps labels Jul 9, 2024
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Jul 9, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Aug 23, 2024
Copy link

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

1 participant