Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Remove multiple copies of UefiVariableSupportLib.py #481

Closed
apop5 opened this issue May 2, 2024 · 1 comment
Closed

[Feature]: Remove multiple copies of UefiVariableSupportLib.py #481

apop5 opened this issue May 2, 2024 · 1 comment
Assignees
@apop5
Labels
complexity:easy Requires minimal background information and effort to accomplish language:python Pull requests that update Python code state:backlog In the backlog type:feature-request A new feature proposal urgency:low Little to no impact

Comments

@apop5
Copy link
Contributor

apop5 commented May 2, 2024

Feature Overview

Currently there are 3 copies of UefiVariableSupportLib in MU_PLUS.

AdvLoggerPkg\Application\DecodeUefiLog\UefiVariablesSupportLib.py
UefiTestingPkg\AuditTests\UefiVarLockAudit\Windows\UefiVariablesSupportLib.py
MfciPkg/Application/MfciPolicy/UefiVariableSupport/UefiVariablesSupportLib.py

Solution Overview

Create UefiVariableSupportLib functionality into Edk2-pytool-extensions

https://github.com/tianocore/edk2-pytool-extensions/tree/master/edk2toolext/windows

And consolidate all the existing functionality to use that version.

Alternatives Considered

No response

Urgency

Low

Are you going to implement the feature request?

I will implement the feature

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@apop5 apop5 added state:backlog In the backlog complexity:easy Requires minimal background information and effort to accomplish type:feature-request A new feature proposal language:python Pull requests that update Python code labels May 2, 2024
@apop5 apop5 self-assigned this May 2, 2024
@github-actions github-actions bot added the urgency:low Little to no impact label May 2, 2024
@apop5 apop5 changed the title [Feature]: Remove multiple copies of [Feature]: Remove multiple copies of UefiVariableSupportLib.py May 2, 2024
@apop5
Copy link
Contributor Author

apop5 commented Oct 24, 2024

Handled in the following PRs

#598
#500

@apop5 apop5 closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apop5 apop5

Labels
complexity:easy Requires minimal background information and effort to accomplish language:python Pull requests that update Python code state:backlog In the backlog type:feature-request A new feature proposal urgency:low Little to no impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apop5