[Bug]: Cleanup AdvLogger After Buffer Offset Change #474
Assignees
Labels
state:needs-triage
Needs to triaged to determine next steps
state:stale
Has not been updated in a long time
type:bug
Something isn't working
urgency:medium
Important with a moderate impact
Comments
os-d
added
type:bug
5 tasks
os-d
added a commit
that referenced
this issue
May 13, 2024
## Description Fix an error made in the AdvLogger v5 PR (#471). This is the same fix (but for a different variable name which is why it was mixed on the last fix up) as #483. Usage of mHighAddress (and mMaxAddress) will be evaluated as part of issue #474. - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Tested on Q35, LineParserTestApp was failing because of this. ## Integration Instructions N/A for a platform. For the next Mu integration, this should be combined with the Advanced Logger v5 commit be9a3d2.
|
This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
|
This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
The existing AdvLogger code relies on using pointers to access a lot of AdvLogger fields, however with the new offsets, this is no longer necessary. Each library can be cleaned up to use the offsets in a more sane manner.
Expected Behavior
See above.
Steps To Reproduce
code
Build Environment
Version Information
Urgency
Medium
Are you going to fix this?
I will fix it
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: