Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Advanced Logger Info Uses Pointers Not Offsets #463

Closed
1 task done
os-d opened this issue Apr 12, 2024 · 2 comments
Closed
1 task done

[Bug]: Advanced Logger Info Uses Pointers Not Offsets #463

os-d opened this issue Apr 12, 2024 · 2 comments
Assignees
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@os-d
Copy link
Contributor

os-d commented Apr 12, 2024

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Today the Advanced Logger Info structure has pointers to the LogBuffer and LogCurrent. It is inherently safer to use offsets here as these will always be allocated within the same buffer as the info structure.

Expected Behavior

See Current Behavior.

Steps To Reproduce

See code.

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:
All

Version Information

Top of tree

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@os-d os-d added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps labels Apr 12, 2024
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Apr 12, 2024
@os-d os-d self-assigned this Apr 12, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label May 27, 2024
Copy link

github-actions bot commented Jun 4, 2024

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

1 participant