Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/mu_plus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d19b1ee73f14ed1f4f921daa3ae7116c92acb811
Choose a base ref
...
head repository: microsoft/mu_plus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 12f028aaa23f23d229bdb6b266f736f3ff928ac8
Choose a head ref
  • 7 commits
  • 8 files changed
  • 6 contributors

Commits on Jan 22, 2024

  1. GitHub Action: Bump actions/cache from 3 to 4 (#412)

    Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 22, 2024
    Copy the full SHA
    f1a1461 View commit details

Commits on Jan 23, 2024

  1. Repo File Sync: Support CodeQL Plugin in BaseTools (#416)

    synced local file(s) with
    [microsoft/mu_devops](https://github.com/microsoft/mu_devops).
    
    🤖: View the [Repo File Sync Configuration
    File](https://github.com/microsoft/mu_devops/blob/main/.sync/Files.yml)
    to see how files are synced.
    
    ---
    
    This PR was created automatically by the
    [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action)
    workflow run
    [#7629520553](https://github.com/microsoft/mu_devops/actions/runs/7629520553)
    
    Signed-off-by: Project Mu UEFI Bot <[email protected]>
    uefibot authored Jan 23, 2024
    Copy the full SHA
    b1f42ea View commit details

Commits on Jan 24, 2024

  1. Update pip-requirements.txt (#421)

    ## Description
    
    Updates edk2-pytool-extensions and edk2-pytool-library to work with the
    latest commit of MU_BASECORE
    
    For each item, place an "x" in between `[` and `]` if true. Example:
    `[x]`.
    _(you can also check items in the GitHub UI)_
    
    - [ ] Impacts functionality?
    - **Functionality** - Does the change ultimately impact how firmware
    functions?
    - Examples: Add a new library, publish a new PPI, update an algorithm,
    ...
    - [ ] Impacts security?
    - **Security** - Does the change have a direct security impact on an
    application,
        flow, or firmware?
      - Examples: Crypto algorithm change, buffer overflow fix, parameter
        validation improvement, ...
    - [ ] Breaking change?
    - **Breaking change** - Will anyone consuming this change experience a
    break
        in build or boot behavior?
    - Examples: Add a new library class, move a module to a different repo,
    call
        a function in a new library class in a pre-existing module, ...
    - [ ] Includes tests?
      - **Tests** - Does the change include any explicit test code?
      - Examples: Unit tests, integration tests, robot tests, ...
    - [ ] Includes documentation?
    - **Documentation** - Does the change contain explicit documentation
    additions
        outside direct code modifications (and comments)?
    - Examples: Update readme file, add feature readme file, link to
    documentation
        on an a separate Web page, ...
    
    ## How This Was Tested
    
    N/A
    
    ## Integration Instructions
    
    N/A
    Javagedes authored Jan 24, 2024
    Copy the full SHA
    966192b View commit details

Commits on Jan 25, 2024

  1. Repo File Sync: synced file(s) with microsoft/mu_devops (#418)

    synced local file(s) with
    [microsoft/mu_devops](https://github.com/microsoft/mu_devops).
    
    🤖: View the [Repo File Sync Configuration
    File](https://github.com/microsoft/mu_devops/blob/main/.sync/Files.yml)
    to see how files are synced.
    
    
    
    ---
    
    This PR was created automatically by the
    [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action)
    workflow run
    [#7652167966](https://github.com/microsoft/mu_devops/actions/runs/7652167966)
    
    Signed-off-by: Project Mu UEFI Bot <[email protected]>
    uefibot authored Jan 25, 2024
    Copy the full SHA
    08fb6f1 View commit details
  2. Add call to HdwPortInitialize() when instantiating logger in DXE (#411)

    ## Description
    
    This change adds a call to AdvancedLoggerHdwPortInitialize() when the
    advanced logger is created in the DxeCoreAdvancedLoggerLibConstructor().
    Previously, hardware port was only initalized in AdvancedLoggerGetInfo()
    if the logging info structure was present at a fixed location or in a
    HOB; this would cause writes to the hardware port to potentially fail in
    the path where the logger is not initialized until the Constructor is
    called.
    
    - [x] Impacts functionality?
    - AdvancedLoggerHdwPortInitialize() is now called in the
    DxeCoreAdvancedLoggerLibConstructor if the logger is instantiated there.
    - [ ] Impacts security?
    - [ ] Breaking change?
    - [ ] Includes tests?
    - [ ] Includes documentation?
    
    ## How This Was Tested
    
    Verified on a platform where this was not working due to missing HdwPort
    initialization; verified after this patch that it works as expected.
    
    ## Integration Instructions
    
    N/A
    
    ---------
    
    Co-authored-by: kuqin12 <[email protected]>
    (cherry picked from commit 6d5e0c5)
    joschock authored and kuqin12 committed Jan 25, 2024
    Copy the full SHA
    833db39 View commit details

Commits on Jan 26, 2024

  1. Fixing Advanced logger wrapping unit test (#417)

    # Preface
    
    Please ensure you have read the [contribution
    docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
    to submitting the pull request. In particular,
    [pull request
    guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).
    
    ## Description
    
    The existing shell test will not take the disabled processors into
    account, thus causing the system to have false positive results.
    
    This change updated the logic to tick out disabled cores, removed some
    UT logs to avoid spamming the output and replaced all the returned
    status with UT_ASSERT for easier troubleshooting.
    
    For each item, place an "x" in between `[` and `]` if true. Example:
    `[x]`.
    _(you can also check items in the GitHub UI)_
    
    - [ ] Impacts functionality?
    - **Functionality** - Does the change ultimately impact how firmware
    functions?
    - Examples: Add a new library, publish a new PPI, update an algorithm,
    ...
    - [ ] Impacts security?
    - **Security** - Does the change have a direct security impact on an
    application,
        flow, or firmware?
      - Examples: Crypto algorithm change, buffer overflow fix, parameter
        validation improvement, ...
    - [ ] Breaking change?
    - **Breaking change** - Will anyone consuming this change experience a
    break
        in build or boot behavior?
    - Examples: Add a new library class, move a module to a different repo,
    call
        a function in a new library class in a pre-existing module, ...
    - [x] Includes tests?
      - **Tests** - Does the change include any explicit test code?
      - Examples: Unit tests, integration tests, robot tests, ...
    - [ ] Includes documentation?
    - **Documentation** - Does the change contain explicit documentation
    additions
        outside direct code modifications (and comments)?
    - Examples: Update readme file, add feature readme file, link to
    documentation
        on an a separate Web page, ...
    
    ## How This Was Tested
    
    This change was tested on proprietary hardware with multiple cores.
    
    ## Integration Instructions
    
    N/A
    
    ---------
    
    Co-authored-by: Oliver Smith-Denny <[email protected]>
    (cherry picked from commit 3c47b5f)
    kuqin12 committed Jan 26, 2024
    Copy the full SHA
    832500f View commit details
  2. Adding a more adapt python tooling for Advanced Logger v4 (#415)

    # Preface
    
    Please ensure you have read the [contribution
    docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
    to submitting the pull request. In particular,
    [pull request
    guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).
    
    ## Description
    
    This change will allow the advanced logger parser to handle the v4,
    which would get lines from the same UEFI boot phase without intercepting
    each other. It will also search for the beginning of returned buffer
    with more sophisticated logic.
    
    Resolves #401
    
    For each item, place an "x" in between `[` and `]` if true. Example:
    `[x]`.
    _(you can also check items in the GitHub UI)_
    
    - [x] Impacts functionality?
    - **Functionality** - Does the change ultimately impact how firmware
    functions?
    - Examples: Add a new library, publish a new PPI, update an algorithm,
    ...
    - [ ] Impacts security?
    - **Security** - Does the change have a direct security impact on an
    application,
        flow, or firmware?
      - Examples: Crypto algorithm change, buffer overflow fix, parameter
        validation improvement, ...
    - [ ] Breaking change?
    - **Breaking change** - Will anyone consuming this change experience a
    break
        in build or boot behavior?
    - Examples: Add a new library class, move a module to a different repo,
    call
        a function in a new library class in a pre-existing module, ...
    - [ ] Includes tests?
      - **Tests** - Does the change include any explicit test code?
      - Examples: Unit tests, integration tests, robot tests, ...
    - [ ] Includes documentation?
    - **Documentation** - Does the change contain explicit documentation
    additions
        outside direct code modifications (and comments)?
    - Examples: Update readme file, add feature readme file, link to
    documentation
        on an a separate Web page, ...
    
    ## How This Was Tested
    
    This was tested on both QEMU Q35 and proprietary hardware platform
    returned advanced logger buffer binary.
    
    ## Integration Instructions
    
    N/A
    
    ---------
    
    Co-authored-by: Oliver Smith-Denny <[email protected]>
    kuqin12 and os-d authored Jan 26, 2024
    Copy the full SHA
    12f028a View commit details
Loading