From 9232759a91d11d30c714a3c2188b91b38b690c2c Mon Sep 17 00:00:00 2001
From: Michael Kubacki <michael.kubacki@microsoft.com>
Date: Fri, 20 Dec 2024 17:46:48 -0500
Subject: [PATCH] UefiHidDxeV2: Remove mutable static shared reference (#593)

## Description

Use `addr_of!()` (raw pointer) to prevent a reference being created to
the mutable static variable.

```
  = note: this will be a hard error in the 2024 edition
  = note: this shared reference has lifetime `'static`, but if the
          static ever gets mutated, or a mutable reference is
		  created, then any further use of this shared reference is
		  Undefined Behavior
```

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

- Cargo clippy and build

## Integration Instructions

- N/A

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 HidPkg/UefiHidDxeV2/src/keyboard.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/HidPkg/UefiHidDxeV2/src/keyboard.rs b/HidPkg/UefiHidDxeV2/src/keyboard.rs
index 4772e43d88..746019bdd5 100644
--- a/HidPkg/UefiHidDxeV2/src/keyboard.rs
+++ b/HidPkg/UefiHidDxeV2/src/keyboard.rs
@@ -728,7 +728,7 @@ extern "efiapi" fn on_layout_update(_event: efi::Event, context: *mut c_void) {
 #[cfg(test)]
 mod test {
 
-    use core::{ffi::c_void, mem::MaybeUninit, slice::from_raw_parts_mut};
+    use core::{ffi::c_void, mem::MaybeUninit, ptr, slice::from_raw_parts_mut};
 
     use hii_keyboard_layout::HiiKeyboardLayout;
     use r_efi::{efi, hii, protocols};
@@ -1012,7 +1012,8 @@ mod test {
             keyboard_layout_ptr: *mut protocols::hii_database::KeyboardLayout,
         ) -> efi::Status {
             let mut keyboard_layout_buffer = vec![0u8; 4096];
-            let buffer_size = keyboard_layout_buffer.pwrite(unsafe { &TEST_KEYBOARD_LAYOUT }, 0).unwrap();
+            let buffer_size =
+                keyboard_layout_buffer.pwrite(&unsafe { (*ptr::addr_of!(TEST_KEYBOARD_LAYOUT)).clone() }, 0).unwrap();
             keyboard_layout_buffer.resize(buffer_size, 0);
             unsafe {
                 if keyboard_layout_length.read() < buffer_size as u16 {