From 11bf6a62177889b09a86b0bc60a5cb505d412c55 Mon Sep 17 00:00:00 2001 From: Michael Kubacki Date: Tue, 17 Oct 2023 13:07:36 -0400 Subject: [PATCH] HidPkg/UsbHidDxe: Continue on failure to get descriptor In case a HID device fails to return a HID descriptor, this change will return the error status from UsbHidDriverBindingStart() rather than assert to match previous behavior from HID drivers. The HID IO protocol will not be installed on these devices. Signed-off-by: Michael Kubacki --- HidPkg/UsbHidDxe/UsbHidDxe.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/HidPkg/UsbHidDxe/UsbHidDxe.c b/HidPkg/UsbHidDxe/UsbHidDxe.c index 71d4257f99..8fce088ee8 100644 --- a/HidPkg/UsbHidDxe/UsbHidDxe.c +++ b/HidPkg/UsbHidDxe/UsbHidDxe.c @@ -723,7 +723,6 @@ ReadDescriptors ( Status = UsbGetFullHidDescriptor (UsbHidDevice->UsbIo, UsbHidDevice->InterfaceDescriptor.InterfaceNumber, &UsbHidDevice->HidDescriptor); if (EFI_ERROR (Status)) { - ASSERT_EFI_ERROR (Status); goto ErrorExit; } @@ -895,7 +894,6 @@ UsbHidDriverBindingStart ( Status = ReadDescriptors (UsbHidDevice); if (EFI_ERROR (Status)) { - ASSERT_EFI_ERROR (Status); goto ErrorExit; }