Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Support for Qemu testing broke real system reboot timing #94

Closed
1 task done
mikeytdisco opened this issue May 8, 2023 · 0 comments · Fixed by #95
Closed
1 task done

[Bug]: Support for Qemu testing broke real system reboot timing #94

mikeytdisco opened this issue May 8, 2023 · 0 comments · Fixed by #95
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:high Significant with a critical impact

Comments

@mikeytdisco
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

When running a the UnitTest testcases, after the system restarts, the remote framework isn't connected correctly.

Expected Behavior

The testcase should reboot the system successfully.

Steps To Reproduce

Run one of the Dfci test cases.

Build Environment

all

Version Information

Commit: 3bfb66d4d3d89226be4ff6cb4d1050206b0f6f9d

Urgency

High

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@mikeytdisco mikeytdisco added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels May 8, 2023
@github-actions github-actions bot added the urgency:high Significant with a critical impact label May 8, 2023
Flickdm added a commit that referenced this issue May 17, 2023
Pinging a QEMU virtual system doesn't work for detecting the system
going offline, so the ping was removed from both the offline and online
path of the test cases. However, this broke testing with real system.

Allow all exceptions to signal system not available when waiting for
online or offline.

Fixes #94 

- [x] Impacts functionality?
- [ ] Impacts security?
- [x] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Tested on the QEMU path and a physical system.

## Integration Instructions

N/A

Co-authored-by: Doug Flick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:high Significant with a critical impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant