[Feature]: Support QemuQ35Pkg virtual system for testing the Dfci Test cases #83
Labels
state:needs-triage
Needs to triaged to determine next steps
type:feature-request
A new feature proposal
urgency:medium
Important with a moderate impact
Comments
mikeytdisco
added
state:needs-triage
5 tasks
makubacki
pushed a commit
that referenced
this issue
Apr 28, 2023
…r test (#84) ## Description Fixes #83. This is all changes to the Dfci UnitTest and Docs directories. There is no change to DFCI functionality. Quite a number of little changes needed to support Dfci in a QemuQ35Pkg virtual system. The Q35 environment has fewer settings, so there are fewer settings tested in the Enroll/Unenroll operations. Due to a pending restructure of the settings test, the current settings test will fail due to settings not in Q35. All the other tests have been tested. The restart mechanism needed to be updated to not rely on ping. Since ping isn't forwarded to Q35, Q35 appeared to never go away. DFCI_SupportLib.py needed a lot of changes to pass flake8. This PR will need additional testing using a physical system. - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? This PR will need additional testing using a physical system to ensure the new restart detections mechanism still works. - [x] Includes tests? - [x] Includes documentation? ## How This Was Tested Tested with a QemuQ35Pkg virtual system. ## Integration Instructions N/A --------- Signed-off-by: Michael Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Overview
Allow a QemuQ35Pkg virtual system to act as the Device Under Test to allow testing and verification of the Dfci unit test end to end test cases.
Solution Overview
Mostly minor changes - The easiest network capability for QemuQ35 is an E1000 adapter, and the way that is integrated is that ports are forwarded to from the HOST to the Qemu Guest. Inbound connections are to the HOST IP to a port that is forwarded to the Qemu virtual system. This means that ping is never forwarded to the Qemu virtual system, and the original Dfci test cases used ping to determine when the Device Under Test was present or not.
Alternatives Considered
No response
Urgency
Medium
Are you going to implement the feature request?
I will implement the feature
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: