Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect version of the Serial Number is used by the Dfci validation test #77

Closed
1 task done
mikeytdisco opened this issue Apr 4, 2023 · 1 comment · Fixed by #78
Closed
1 task done

[Bug]: Incorrect version of the Serial Number is used by the Dfci validation test #77

mikeytdisco opened this issue Apr 4, 2023 · 1 comment · Fixed by #78
Assignees
@Flickdm
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@mikeytdisco
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

The DfciPkg\UnitTests\DfciTest testcases all run a command on the device under test to obtain the device manufacturer, product name, and serial number and build packets with this identifying information. It was not clear at the time the tests were made which serial number to use, as all of the devices being tested had the same serial number for the Type1 and Type3 SMBIOS Serial number. That is, until a recent OEM had a laptop with different serial numbers for the Type1 and Type3 tables.

Expected Behavior

The test cases should use the Type1 serial number.

Steps To Reproduce

Run the Dfci_IntuneEnroll testcase with a system that has

  1. Different serial numbers for the Type1 and Type3 BIOS tables
  2. Has a properly fixed DfciDeviceIdSupportLib platform library that sets the DeviceId to the Type1 serial number
  3. Fixes the Robot script to obtain the Type1 serial number for building the packets

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:

Version Information

Tag V2.0.1

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@mikeytdisco mikeytdisco added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Apr 4, 2023
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Apr 4, 2023
@mikeytdisco mikeytdisco mentioned this issue Apr 4, 2023
Merged
5 tasks
@makubacki
Copy link
Member

Assigning to @Flickdm to move the PR to closure

Flickdm added a commit that referenced this issue May 19, 2023
@mikeytdisco @Flickdm
Change the source of the serial number to the Type1 BIOS information … (
4b7acc5 
#78)

…serial number


## Description

A test exemption had to be added for an OEM that has a device with
different Type1 and Type3 serial numbers.
Type1 is the system board, and Type3 is the enclosure or chassis. All
laptops seen prior to this OEM had the same serial number for both Type1
and Type3. Fixes #77

Potentially a breaking change for testing when a Device Under Test has
different serial numbers for Type1 and Type3.

- [ ] Impacts functionality?

- [ ] Impacts security?

- [x] Breaking change?
      
- [x] Includes tests?

- [ ] Includes documentation?


## How This Was Tested

Tested with a fixed DfciDeviceIdSupportLib that used the Type1 SMBIOS
serial number on a Windows DUT in a QemuQ35Pkg environment with
different smbios serial numbers. The DfciDeviceIdSupportLib is a
platform provided library.

## Integration Instructions

N/A

Co-authored-by: Doug Flick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flickdm Flickdm

Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the source of the serial number to the Type1 BIOS information … mikeytdisco/mu_feature_dfci
3 participants
@Flickdm @mikeytdisco @makubacki