Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate name error when adding second firewall rule #73

Merged

Conversation

mikeytdisco
Copy link
Contributor

@mikeytdisco mikeytdisco commented Apr 4, 2023

Description

Originally tested on a system where the firewall was disabled, so the missing firewall entry error was not observed. Fixes #74

  • Impacts functionality?

  • Impacts security?

  • Breaking change?

  • Includes tests?

    • Changes the setup script
  • Includes documentation?

How This Was Tested

Tested configuring a Windows Guest running in a QemuQ35Pkg VM.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:testing Affects testing label Apr 4, 2023
@spbrogan spbrogan force-pushed the personal/mikeyt/FixForSetupDUT branch from 3e7ff37 to 3717003 Compare April 6, 2023 17:17
@spbrogan spbrogan merged commit 4cd4265 into microsoft:main Apr 6, 2023
@mikeytdisco mikeytdisco deleted the personal/mikeyt/FixForSetupDUT branch April 7, 2023 17:53
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 20, 2023
…rom `2.0.2` to `2.3.1`.

Introduces 6 new commits.

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 20, 2023
…rom `2.0.2` to `2.3.1`.

Introduces 6 new commits.

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 21, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 21, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 22, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 22, 2023
Bumps Features/DFCI from `2.0.2` to `2.3.1`

Introduces 6 new commits in
[Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a>
[Bug] Revert invalid change which breaks DFCI Refresh from network. (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a>
Make DFCI Lock Var Runtime accessible (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a>
Revert VarPolicy locking change (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a>
Fix memory leak (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a>
Fix duplicate name error when adding second firewall rule (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a>
Remove references to a function removed long ago (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error message from script when setting up a Device Under Test
3 participants