Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Memory leaks in RestoreCertificates(), EnableDfciCertificate() & ProcessHttpRequest() #65

Closed
1 task done
wenbhou opened this issue Mar 31, 2023 · 0 comments · Fixed by #66
Closed
1 task done

[Bug]: Memory leaks in RestoreCertificates(), EnableDfciCertificate() & ProcessHttpRequest() #65

wenbhou opened this issue Mar 31, 2023 · 0 comments · Fixed by #66
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact

Comments

@wenbhou
Copy link
Contributor

wenbhou commented Mar 31, 2023

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Memory leak is observed in RestoreCertificates(), EnableDfciCertificate() & ProcessHttpRequest()

Expected Behavior

There should be no memory leak in code.

Steps To Reproduce

Reading the code, found the memory allocated from pool, was not freed properly

Build Environment

- OS(s): Windows 11
- Tool Chain(s): VS2022
- Targets Impacted: DEBUG

Version Information

3b324ef716d609367e32480c96bdbbaf28c1f581

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@wenbhou wenbhou added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Mar 31, 2023
@github-actions github-actions bot added the urgency:low Little to no impact label Mar 31, 2023
@wenbhou wenbhou mentioned this issue Mar 31, 2023
Merged
5 tasks
makubacki pushed a commit that referenced this issue Apr 4, 2023
@wenbhou
Fix memory leak (#66)
769a609 
## Description

Fix #65

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Run standard testing:

1. DFCI_InitialState
2. DFCI_InTuneEnroll
3. DFCI_InTuneRollCerts
4. DFCI_InTunePermissions
5. DFCI_InTuneSettings
6. DFCI_InTuneBadUpdate
7. DFCI_InTuneUnenroll

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DfciPkg/DfciMenu: Fix memory leaks wenbhou/mu_feature_dfci
1 participant
@wenbhou