Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DFCI Lock Var Runtime accessible #64

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

spbrogan
Copy link
Member

Description

Due to how Variable Locking works the lock variable should be runtime accessible.

  • Impacts functionality?
  • Impacts security?

How This Was Tested

Code inspection

Integration Instructions

NA

@github-actions github-actions bot added the impact:security Has a security impact label Mar 31, 2023
@spbrogan spbrogan linked an issue Mar 31, 2023 that may be closed by this pull request
1 task
@spbrogan spbrogan added type:bug Something isn't working semver:minor Pull requests that should increment the release minor version labels Mar 31, 2023
@Javagedes Javagedes merged commit 4bf67f2 into main Mar 31, 2023
@Javagedes Javagedes deleted the user/sebrogan/locking_issue branch March 31, 2023 18:20
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 20, 2023
…rom `2.0.2` to `2.3.1`.

Introduces 6 new commits.

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 20, 2023
…rom `2.0.2` to `2.3.1`.

Introduces 6 new commits.

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in makubacki/mu_tiano_platforms Apr 20, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 21, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 21, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 22, 2023
Introduces 6 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a> [Bug] Revert invalid change which breaks DFCI Refresh from network. (<a href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a> Make DFCI Lock Var Runtime accessible (<a href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a> Revert VarPolicy locking change (<a href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a> Fix memory leak (<a href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a> Fix duplicate name error when adding second firewall rule (<a href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a> Remove references to a function removed long ago (<a href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 22, 2023
Bumps Features/DFCI from `2.0.2` to `2.3.1`

Introduces 6 new commits in
[Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/3b324ef716d609367e32480c96bdbbaf28c1f581">3b324e</a>
[Bug] Revert invalid change which breaks DFCI Refresh from network. (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/61">#61</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/4bf67f28993390a8fbdbd1522ffb838c3ab8c236">4bf67f</a>
Make DFCI Lock Var Runtime accessible (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/64">#64</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/0fc28dd31eaa21ff68a373dd1da40e42954ba46a">0fc28d</a>
Revert VarPolicy locking change (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/70">#70</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/769a6091b42e44b69195dc72f30c38d4bd7782df">769a60</a>
Fix memory leak (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/66">#66</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/4cd4265bb0431ea341f2cdee6495b5c2c8a8e904">4cd426</a>
Fix duplicate name error when adding second firewall rule (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/73">#73</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/426e8d513de072734935d7d38b5dd9aac606e0ba">426e8d</a>
Remove references to a function removed long ago (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/76">#76</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:security Has a security impact semver:minor Pull requests that should increment the release minor version type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DFCI variable is not locked in some cases
3 participants