Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buffer size for string of DFCI setting #36

Merged

Conversation

wenbhou
Copy link
Contributor

@wenbhou wenbhou commented Feb 28, 2023

Fixes #41

Description

  1. Increase ENABLED_STRING_SIZE & USB_PORT_STATE_STRING_SIZE so that the buffer allocated can be big enough to accommodate the string of DFCI setting, otherwise the generated DFCI setting string will be truncated.
  2. Remove define of ASSET_TAG_STRING_MAX_SIZE which is no longer used.
  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Verified with SEMM tool:

  1. Set USB port to UsbPortAuthenticated via ConfigureSEMM.ps1
  2. Reboot
  3. Verify with CurrentSettings.ps1. The USB port is in correct mode.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Feb 28, 2023
@wenbhou wenbhou force-pushed the personal/wenbhou/update_buffer_size branch from 5c41480 to 4dd1942 Compare March 1, 2023 02:58
@wenbhou wenbhou requested a review from mikeytdisco March 1, 2023 16:24
@github-actions github-actions bot removed the impact:non-functional Does not have a functional impact label Mar 2, 2023
@mikeytdisco mikeytdisco enabled auto-merge (squash) March 2, 2023 00:48
@mikeytdisco mikeytdisco merged commit 1e35d78 into microsoft:main Mar 2, 2023
@wenbhou wenbhou deleted the personal/wenbhou/update_buffer_size branch March 7, 2023 03:26
@makubacki makubacki added the type:bug Something isn't working label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Buffer size not big enough for DFCI setting strings
3 participants