Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CreateDockerContainer.bat fails to generate image #234

Closed
1 task done
cmruffin opened this issue Jul 25, 2024 · 0 comments · Fixed by #236
Closed
1 task done

[Bug]: CreateDockerContainer.bat fails to generate image #234

cmruffin opened this issue Jul 25, 2024 · 0 comments · Fixed by #236
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact

Comments

@cmruffin
Copy link
Contributor

cmruffin commented Jul 25, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

CreateDockerContainer.bat can fail in python 3.11 environments that have version of pip that disallows modifying non-virtual environments.

Expected Behavior

CreateDockerContainer.bat successfully creates the docker image.

Steps To Reproduce

cd mu_feature_dfci\DfciPkg\UnitTests\DfciTests
pip install -r pip_requirements.txt
pip install --upgrade pip
cd RefreshServer
CreateDockerContainer.bat

Build Environment

- OS(s):win10
- Tool Chain(s):
- Targets Impacted:

Version Information

981a67c31e0334583b60ab08a3dd252c11e59432

Urgency

Low

Are you going to fix this?

I will fix this.

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

fix is patch to Dockerfile:

pip3 install --break-system-packages cython cherrypy flask pyOpenSSL
@cmruffin cmruffin added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Jul 25, 2024
@github-actions github-actions bot added urgency:low Little to no impact labels Jul 25, 2024
@cmruffin cmruffin mentioned this issue Jul 25, 2024
Merged
5 tasks
makubacki pushed a commit that referenced this issue Aug 6, 2024
@cmruffin
DfciPkg/DfciTests: fix refresh server pip failure (#236)
514e152 
## Description

Adds a command line switch to a pip command in the dockerfile. This
allows the docker image creation process to pass.

`--break-system-packages` was introduced in pip 23.0.1.

- https://pip.pypa.io/en/stable/news/#v23-0-1

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Built on Windows 10.

## Integration Instructions

N/A

Fixes #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DfciPkg/DfciTests: fix refresh server pip failure cmruffin/mu_feature_dfci
1 participant
@cmruffin