[Bug]: Changing the source of the serial number to the Type1 BIOS information causing issues within an OEM

[Flickdm]

Is there an existing issue for this?

• I have searched existing issues

Current Behavior

Description

The DfciPkg\UnitTests\DfciTest testcases all run a command on the device under test to obtain the device manufacturer, product name, and serial number and build packets with this identifying information. It was not clear at the time the tests were made which serial number to use, as all of the devices being tested had the same serial number for the Type1 and Type3 SMBIOS Serial number. That is, until a recent OEM had a laptop with different serial numbers for the Type1 and Type3 tables.

A (recent change was made to test that OEMS are using Type 01 instead of Type 3.

Expected Behavior

The test cases should use the Type3 serial number.

Steps To Reproduce

Run the Dfci_IntuneEnroll testcase with a system that has

Different serial numbers for the Type1 and Type3 BIOS tables
Has a properly fixed DfciDeviceIdSupportLib platform library that sets the DeviceId to the Type3 serial number
Fixes the Robot script to obtain the Type3 serial number for building the packets

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:

Version Information

3.0.0

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

[Flickdm]

Type 01 is by design. This is what Intune expects - not Type 03. Type 01 is the correct form.