From ad6ed3c290c2923ab3a970abd04e24ca92f2b406 Mon Sep 17 00:00:00 2001 From: Michael Kubacki Date: Mon, 27 Nov 2023 11:50:24 -0500 Subject: [PATCH] Use New Stack Cookie Library (#219) ## Description MinPlatformPkg/Include/CoreCommonLib.dsc includes MdePkg/MdeLibs.dsc.inc to bring in the new stack cookie library instances from there. - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [x] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested - MinPlatformPkg build and CI ## Integration Instructions - N/A Signed-off-by: Michael Kubacki --- MinPlatformPkg/MinPlatformPkg.dsc | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/MinPlatformPkg/MinPlatformPkg.dsc b/MinPlatformPkg/MinPlatformPkg.dsc index c912b96797..c87a3bcef7 100644 --- a/MinPlatformPkg/MinPlatformPkg.dsc +++ b/MinPlatformPkg/MinPlatformPkg.dsc @@ -86,17 +86,6 @@ # MU_CHANGE [END] TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf TestPointPciSpeedInfoLib|MinPlatformPkg/Library/TestPointPciSpeedInfoLibNull/TestPointPciSpeedInfoLibNull.inf -##MSCHANGE Begin - BaseBinSecurityLib|MdePkg/Library/BaseBinSecurityLibNull/BaseBinSecurityLibNull.inf -!if $(TOOL_CHAIN_TAG) == VS2019 or $(TOOL_CHAIN_TAG) == VS2022 -[LibraryClasses.X64, LibraryClasses.IA32] - #if debug is enabled provide StackCookie support lib so that we can link to /GS exports on MSVC - RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf -[LibraryClasses.X64] - BaseBinSecurityLib|MdePkg/Library/BaseBinSecurityLibRng/BaseBinSecurityLibRng.inf - NULL|MdePkg/Library/BaseBinSecurityLibRng/BaseBinSecurityLibRng.inf -!endif -##MSCHANGE End [LibraryClasses.common.SEC] TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/SecTestPointCheckLib.inf