Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Stack Protect for PEIM in IA32 #695

Closed
MarcChen46 opened this issue Jan 25, 2024 · 2 comments
Closed

[Feature]: Stack Protect for PEIM in IA32 #695

MarcChen46 opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal urgency:high Significant with a critical impact

Comments

@MarcChen46
Copy link
Contributor

Feature Overview

Current stack protect feature has not support PEIM in IA32 yet, it is critical to get the stack protect in both PEI and DXE phase, please plan to implement the stack protect for PEIM in IA32 and it would be great if it can be completed in early February.

Solution Overview

Provide the same stack protect feature as DXE phase by StackCheckLib.

Alternatives Considered

No response

Urgency

High

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

@apop5 @TaylorBeebe

@MarcChen46 MarcChen46 added state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal labels Jan 25, 2024
@github-actions github-actions bot added state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps urgency:high Significant with a critical impact state:needs-owner Needs an issue owner to be assigned labels Jan 25, 2024
@apop5 apop5 removed the state:needs-owner Needs an issue owner to be assigned label Jan 29, 2024
@TaylorBeebe
Copy link
Contributor

TaylorBeebe commented Feb 2, 2024

A PR for this has been posted: #714

This PR requires some CI issues to be resolved:

  1. The build-time stack cookie logic requires edits to base tools. In CI, we use the EDK2 basetools from Tianocore. The EDK2 basetools can either be dropped from pip-requirements, or the setting in CISettings should be updated to specify that the local basetools should be used.

  2. Sometimes, more than one stack cookie library can be included for a module. This is inconsistent and only seems to happen in CI which indicates there may be a bug in basetools. This is being investigated.

@TaylorBeebe
Copy link
Contributor

This feature has been committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal urgency:high Significant with a critical impact
Projects
None yet
Development

No branches or pull requests

3 participants