-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Support host based unit test on ARM systems #495
Comments
This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Took a look at the ARM builds, the cmocka solutions are easily adoptable, with minimal changes (given current usage). See here: https://github.com/kuqin12/mu_basecore/tree/unit_test_arm64 However, the google test pulled in subhook submodule, which is only compatible with x86 systems.. Need to bring up to folks from Google to see if they are interested in supporting this. |
This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
We will bring this to EDK2 for broader discussion. Keep this open, please. |
This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
Feature Overview
Today's host based unit test is heavily based on x86 architecture. As more targets are for ARM/AARCH64 systems nowadays, there is more need for running host based unit tests on the same architecture as the targets for better test fidelity.
However, the current host based unit test framework mainly builds for x86 systems and would introduce build breaks if we want to compile host based unit tests for AARCH64. i.e. this structure does not exist on ARM systems: https://github.com/microsoft/mu_basecore/blob/3f022dad7ac0035cfe3ed49a12403a7314445383/MdePkg/Test/UnitTest/Include/Library/UnitTestHostBaseLib.h#L88C20-L88C20.
Solution Overview
Plum through the build break when building on host based unit on ARM system and start to deploy the existing host based unit tests to ARM builds (Windows and Linnux).
There might be further tuning for plugins to make the entire flow functional.
Alternatives Considered
No response
Urgency
Medium
Are you going to implement the feature request?
Someone else needs to implement the feature
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: