From ff2644f4c4ce9a9b3cb165800e874ff9ae28bbfa Mon Sep 17 00:00:00 2001 From: kuqin12 <42554914+kuqin12@users.noreply.github.com> Date: Tue, 3 Oct 2023 08:40:34 -0700 Subject: [PATCH] Fixing the string matching for Windows ARM64 system (#584) # Preface Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). ## Description Python platform inquiry will return `Windows` and `ARM64` for OS name and architecture, respectively. This change will update the value to match that, and thus properly skip rust coverage step from this plugin. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested This was tested on Windows ARM64 system. ## Integration Instructions N/A --- .pytool/Plugin/RustHostUnitTestPlugin/RustHostUnitTestPlugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pytool/Plugin/RustHostUnitTestPlugin/RustHostUnitTestPlugin.py b/.pytool/Plugin/RustHostUnitTestPlugin/RustHostUnitTestPlugin.py index b053e66b65c..e0d78170cad 100644 --- a/.pytool/Plugin/RustHostUnitTestPlugin/RustHostUnitTestPlugin.py +++ b/.pytool/Plugin/RustHostUnitTestPlugin/RustHostUnitTestPlugin.py @@ -26,7 +26,7 @@ def RunBuildPlugin(self, packagename, Edk2pathObj, pkgconfig, environment, PLM, with_coverage = pkgconfig.get("CalculateCoverage", True) - if platform.system() == "Windows" and platform.machine() == 'aarch64': + if platform.system() == "Windows" and platform.machine() == 'ARM64': logging.debug("Coverage skipped by plugin, not supported on Windows ARM") with_coverage = False