From 205d4e91f4ab61cb3cd4d56b926a980242194e41 Mon Sep 17 00:00:00 2001
From: Oliver Smith-Denny <osde@microsoft.com>
Date: Thu, 14 Sep 2023 10:41:40 -0700
Subject: [PATCH] Fix Redefined Callback (#566)

## Description

RuntimeLibExitBootServicesEventCallback is defined and exported in two
locations, RuntimeLib and PolicyLib. This causes a linker error if both
libraries are linked to a module.

This patch both changes the name of the callback in PolicyLib (as this
was not an accurate name) and marks it STATIC, as this function should
not be called at all except for the function pointer that is registered
for the event firing.

Closes #565.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Unit tests ran.

## Integration Instructions

N/A.
---
 PolicyServicePkg/Library/DxePolicyLib/DxePolicy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/PolicyServicePkg/Library/DxePolicyLib/DxePolicy.c b/PolicyServicePkg/Library/DxePolicyLib/DxePolicy.c
index f00a7e7043..6d9cd87082 100644
--- a/PolicyServicePkg/Library/DxePolicyLib/DxePolicy.c
+++ b/PolicyServicePkg/Library/DxePolicyLib/DxePolicy.c
@@ -68,9 +68,10 @@ GetPolicyInterface (
   @param[in]  Context The Event Context.
 
 **/
+STATIC
 VOID
 EFIAPI
-RuntimeLibExitBootServicesEvent (
+PolicyExitBootServicesEventCallback (
   IN EFI_EVENT  Event,
   IN VOID       *Context
   )
@@ -101,7 +102,7 @@ PolicyLibConstructor (
   Status = gBS->CreateEvent (
                   EVT_SIGNAL_EXIT_BOOT_SERVICES,
                   TPL_NOTIFY,
-                  RuntimeLibExitBootServicesEvent,
+                  PolicyExitBootServicesEventCallback,
                   NULL,
                   &mPolicyExitBootServicesEvent
                   );