SymbolIcon broken in non english languages.

[ZH-PurpleFox]

Describe the bug

The control symbolIcon of Winui3 will cause garbled code in non English environments

Steps to reproduce the bug

 ##<SymbolIcon Symbol="Refresh"></SymbolIcon>

Expected behavior

The control will be garbled instead of the expected Symbol.

Screenshots

NuGet package version

None

Windows version

Windows 10 (21H2): Build 19044

Additional context

No response

[Jay-o-Way]

I know exactly why: MicrosoftDocs/winrt-api#2363
Shame on Microsoft, for not having this fixed years ago.

[Jay-o-Way]

SymbolIcon is practically deprecated. See #5887 (comment)
Use a FontIcon.

[Jay-o-Way]

Hi @llongley can you explain how this issue is fixed?

[codendone]

@Jay-o-Way Looking at the internal issue, it looks like this was the fix: #8379. This fix was also in WinAppSDK 1.4.

[karkarl]

Hey @Jay-o-Way, the fix for this issue was in 2 parts:

1. Update FontIcons in existing controls for WinUI2 & WInUI3 to the appropriate glyphs
2. Update the SymbolEnum to also map to the appropriate glyphs

The linked comment above (#8379) was to update the controls in WinUI2. The same fix was ported over to WinUI3, and a separate PR was merged in for SymbolEnum. Both these PRs are internal and serviced for WASDK 1.4. Please let me know if you are still able to repro this issue.

Please reference the comment here explaining.

[Jay-o-Way]

Okay, so it's internal and thus invisible, right? That's good to know. A comment like such would have been nice.

[karkarl]

Okay, so it's internal and thus invisible, right? That's good to know. A comment like such would have been nice.

Actually, WinUI3 source is available now! Here's the code that maps the glyphs for your reference: https://github.com/microsoft/microsoft-ui-xaml/blob/winui3/release/1.5-stable/dxaml/xcp/core/core/elements/icon.cpp#L448

Note that the decision to write a map rather than replacing the glyphs explicitly is to avoid any breaking changes in the SymbolEnum API (and a whole formal API review).

[Jay-o-Way]

@karkarl thank you so much! I absolutely love the quality of your communication! You're the best!