Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-cdn.net not forwarded on Live Share → e.g., vscode-pdf fails #5095

Open
SichangHe opened this issue Aug 11, 2024 · 0 comments
Open

Comments

@SichangHe
Copy link

I tried to preview a PDF in a VSCode Live Share session, but none of the extensions on the marketplace works. E.g., this is what vscode-odf shows:
PDF previewer error

I opened up the webview DevTools console and found out the extensions failed to receive the PDF at all:
Console PDF error

Pressing the Download button of vscode-pdf reveals the culprit: it sends me to https://vsls+.vscode-resource.vscode-cdn.net/MY_PDF_NAME.pdf#pdfjs.action=download, an unreachable URL.

There are various other error messages about failing to fetch remote embedding cache from https://embeddings.vscode-cdn.net, etc., showing that vscode-cdn.net is not forwarded correctly in Live Share.

Motivation to fix this issue

This issue renders VSCode Live Share strictly inferior to Google Doc, and affects GitHub Codespaces. In #3372, #3624, and #1895, people discovered that PDF and image preview does not work in Live Share. Many more extensions relies on vscode-cdn.net to fetch resources, and they likely all fail in Live Share. In fact, I cannot find any way to view images in Live Share, a fundamental capability.

What was your system configuration?
Product and Version [VS/VSCode]: 1.92.1 eaa41d57266683296de7d118f574d0c2652e1fc4 arm64
OS Version: macOS
Live Share Extension Version: 2024-08-07, 00:11:02
Target Platform or Language: PDF

Please attach logs to this issue: live-share-logs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant