Initial fixes to restore Java IT #5632
Conversation
| @@ -21,7 +21,7 @@ if ($language -eq "csharp") { | |||
| $command = " --output `"./it/$language/client`" --namespace-name `"app.client`"" | |||
| } | |||
| elseif ($language -eq "java") { | |||
| $command = " --output `"./it/$language/src`"" | |||
| $command = " --output `"./it/$language/src/apisdk`"" | |||
There was a problem hiding this comment.
This is, likely, another breaking change of the "default behavior".
There was a problem hiding this comment.
meaning it'll break other integration tests or did you mean something else?
There was a problem hiding this comment.
When I implemented the IT tests, the CLI was correctly placing the files in the folder matching the package name, now it's not.
I haven't bisected the issue to see what changed, though, was the previous "default package" null?
There was a problem hiding this comment.
I went ahead and merged my earlier PR #5624 to avoid having competing work. Updated this one from main.
It seems that all those changes do not solve the parsable issue.
https://github.com/microsoft/kiota/actions/runs/11401393719/job/31726688511?pr=5632
| @@ -21,7 +21,7 @@ if ($language -eq "csharp") { | |||
| $command = " --output `"./it/$language/client`" --namespace-name `"app.client`"" | |||
| } | |||
| elseif ($language -eq "java") { | |||
| $command = " --output `"./it/$language/src`"" | |||
| $command = " --output `"./it/$language/src/apisdk`"" | |||
There was a problem hiding this comment.
meaning it'll break other integration tests or did you mean something else?
|
ok so after looking more into it, all the parsable errors can be ignored. They are a side effect of the circular reference for the integration model. |
|
(I'll keep sharing my findings on the original issue) |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
This PR is only fixing the most evident issues with the Java IT tests.
fixes #5610