Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings about discriminator not being inherited #4761

Closed
andrueastman opened this issue Jun 3, 2024 · 0 comments · Fixed by #4762
Closed

Warnings about discriminator not being inherited #4761

andrueastman opened this issue Jun 3, 2024 · 0 comments · Fixed by #4762
Assignees
@andrueastman
Labels
type:bug A broken experience
Milestone
Kiota v1.15

Comments

@andrueastman
Copy link
Member

andrueastman commented Jun 3, 2024 •
edited
Loading

Since commit 448af8f (which is the first of this pull request) I see a lot of warnings about discriminator not being inherited when generating my client. For example:

Discriminator SObjectRootInfo is not inherited from SObjectRootInfo.

The generated code is identical, only the warnings are new.

This problem can be reproduced by debugging the AddsDiscriminatorMappingsAllOfImplicit test and setting a breakpoint on logger.LogWarning("Discriminator {ComponentKey} is not inherited from {ClassName}.", componentKey, baseClass.Name); in the KiotaBuilder.cs file.

Originally posted by @0xced in #4723 (comment)
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jun 3, 2024
@andrueastman andrueastman mentioned this issue Jun 3, 2024
Merged
@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Jun 3, 2024
@andrueastman andrueastman added the type:bug A broken experience label Jun 3, 2024
@andrueastman andrueastman self-assigned this Jun 3, 2024
@andrueastman andrueastman added this to the Kiota v1.15 milestone Jun 3, 2024
@andrueastman andrueastman mentioned this issue Jun 3, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Jun 3, 2024
@BrewTestBot BrewTestBot mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrueastman andrueastman

Labels
type:bug A broken experience
Projects
Kiota
Archived in project
Milestone
Kiota v1.15
Development

Successfully merging a pull request may close this issue.

Fixes a bug where warnings about discriminator not being inherited were generated microsoft/kiota
1 participant
@andrueastman