Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C# code generation to follow the usual C# code style #4625

Closed
Balkoth opened this issue May 8, 2024 · 3 comments · Fixed by #4652
Closed

Change C# code generation to follow the usual C# code style #4625

Balkoth opened this issue May 8, 2024 · 3 comments · Fixed by #4652
Assignees
@Balkoth
Labels
Csharp Pull requests that update .net code enhancement New feature or request help wanted Issue caused by core project dependency modules or library type:feature New experience request
Milestone
Kiota v1.15

Comments

@Balkoth
Copy link
Contributor

Balkoth commented May 8, 2024 •
edited
Loading

Client library/SDK language

Csharp

Describe the solution you'd like

There is #4347 and #4348 but there are still the following cases left:

  • Put opening brace after namespace definition on new line image

  • Put opening brace after property definition on new line, if property has getter and setter image

  • Put spaces correctly around dictionary entries image

  • Remove trailing space after class definition image

Can submit a PR.
@Balkoth Balkoth added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels May 8, 2024
@msgraph-bot msgraph-bot bot added this to Kiota May 8, 2024
@github-project-automation github-project-automation bot moved this to Todo 📃 in Kiota May 8, 2024
@Balkoth Balkoth changed the title Put braces on new line in CSharp generator Pt.2 Change C# code generation to follow the usual C# code style May 8, 2024
@baywet baywet added enhancement New feature or request help wanted Issue caused by core project dependency modules or library Csharp Pull requests that update .net code and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels May 8, 2024
@baywet
Copy link
Member

baywet commented May 8, 2024

Hi @Balkoth
Thanks for using kiota and for reaching out.
Can you provide diffs for the changes you mentioned please? just to make sure we're on the same page before you do any work.

@Balkoth
Copy link
Contributor Author

Balkoth commented May 13, 2024

For diffs see op now.

@baywet
Copy link
Member

baywet commented May 13, 2024

Thanks for providing those. Yes it'd be beneficial as closer to C# conventions.
Please go ahead with a pull request.
And let us know if you need pointers.

@baywet baywet added this to the Backlog milestone May 13, 2024
@Balkoth Balkoth mentioned this issue May 13, 2024
Merged
@baywet baywet modified the milestones: Backlog, Kiota v1.15 May 13, 2024
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota May 13, 2024
@BrewTestBot BrewTestBot mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balkoth Balkoth

Labels
Csharp Pull requests that update .net code enhancement New feature or request help wanted Issue caused by core project dependency modules or library type:feature New experience request
Projects
Kiota
Archived in project
Milestone
Kiota v1.15
Development

Successfully merging a pull request may close this issue.

Change C# code generation to follow the usual C# code style Balkoth/kiota
2 participants
@baywet @Balkoth