kiota-lock.json contains absolute path in descriptionLocation

[jods4]

When using the command line, if code is generated with

dotnet kiota --openapi ./my-api.json

Then the lock file will contain the absolute path to my-api.json.

This is not portable in collaborative environments, where people might check out source code in different locations.

If descriptionLocation is a file, it should be stored as a relative path from the kiota-lock.json, so that dotnet kiota update works for everyone.

[baywet]

Thanks for reporting this, is this something you'd be willing to submit a pull request for?

Here is where the lockfile gets written

kiota/src/Kiota.Builder/Lock/LockManagementService.cs

Line 67 in cc3b54c

private static async Task WriteLockFileInternalAsync(string directoryPath, KiotaLock lockInfo, CancellationToken cancellationToken)

[jods4]

If you accept PR, yes I can submit one.
Right now I'm about to be on a leave until end of September but if nobody picks this up I might have a look when I come back.

[baywet]

@jods4 is this something you're still willing to work on?

[jods4]

@baywet Sorry I forgot to come back to you, I've been quite busy since I came back.

There was a turn of events and maybe we'll pivot to Refitter to generate strongly typed api clients in our project.
If we stick to Kiota then yes I will contribute this; on the other hand if we don't use Kiota then I'm afraid I won't have time for this.

To be honest with you: it's not final yet but highly likely that we switch to Refitter.

[baywet]

no worries, what were (will be) the deciding factors?

[jods4]

Refit is a great library to work with apis that do not have OpenAPI specs, which is unfortunately something we must do.

Once we've fully integrated Refit (config, logging, credentials mgmt, httpclient lifetime, etc.) it simply makes sense to use it for OpenAPI too (with Refitter), rather than adopt a second, different http library.

[baywet]

Thanks for the transparent feedback!

[jods4]

No problem, thanks for your work on Kiota!