-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove normalization from writers #2842
Comments
@andreaTP would you be willing to take on this work? |
Hi @sebastienlevert , sorry for the delay I was on PTO 🙂 I started looking at this issue; unfortunately, it seems more profound than I initially thought. I'll be grateful if someone in the core team is willing to tackle this. |
Invoking @baywet for chiming in here. But I agree these should happen upstream to allow for an easier use downstream. |
Once the code migration is complete, we should investigate building a custom analyzer to prevent any regression. |
re-opening as this still needs to be done for other languages. |
Normalization of names should happen in the refiners to allow other phases to reuse the information.
Currently, Python and Ruby are performing the normalization in the writers, and this is causing a bunch of issues.
We should move the normalization back to the refiners.
The text was updated successfully, but these errors were encountered: