Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normalization from writers #2842

Open
andreaTP opened this issue Jul 3, 2023 · 5 comments · Fixed by #3423
Open

Remove normalization from writers #2842

andreaTP opened this issue Jul 3, 2023 · 5 comments · Fixed by #3423
Assignees
Labels
enhancement New feature or request generator Issues or improvements relater to generation capabilities. help wanted Issue caused by core project dependency modules or library PHP Python WIP
Milestone

Comments

@andreaTP
Copy link
Contributor

andreaTP commented Jul 3, 2023

Normalization of names should happen in the refiners to allow other phases to reuse the information.

Currently, Python and Ruby are performing the normalization in the writers, and this is causing a bunch of issues.

We should move the normalization back to the refiners.

@baywet baywet added this to the Kiota v1.5 milestone Jul 3, 2023
@baywet baywet added enhancement New feature or request help wanted Issue caused by core project dependency modules or library generator Issues or improvements relater to generation capabilities. labels Jul 3, 2023
@baywet baywet added this to Kiota Jul 3, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Jul 3, 2023
@sebastienlevert
Copy link
Contributor

@andreaTP would you be willing to take on this work?

@andreaTP
Copy link
Contributor Author

andreaTP commented Aug 7, 2023

Hi @sebastienlevert , sorry for the delay I was on PTO 🙂

I started looking at this issue; unfortunately, it seems more profound than I initially thought.
In the ./src/Kiota.Builder/Writers/Python there are 75 occurrences of .ToSnakeCase() and, in some places, assignments are done again by mangling the name with propertyType.Name.ToFirstCharacterUpperCase().

I'll be grateful if someone in the core team is willing to tackle this.
If you are short on resources I can prioritize it, but this is going to need more coordination than expected.

@sebastienlevert
Copy link
Contributor

Invoking @baywet for chiming in here. But I agree these should happen upstream to allow for an easier use downstream.

@baywet
Copy link
Member

baywet commented Sep 20, 2023

Once the code migration is complete, we should investigate building a custom analyzer to prevent any regression.

@baywet baywet moved this from Todo to In Progress in Kiota Sep 20, 2023
@baywet baywet modified the milestones: Kiota v1.7, Kiota v1.8 Oct 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Oct 10, 2023
@baywet baywet reopened this Oct 10, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Kiota Oct 10, 2023
@baywet
Copy link
Member

baywet commented Oct 10, 2023

re-opening as this still needs to be done for other languages.
If you could address PHP next, it'd be great.

@baywet baywet modified the milestones: Kiota v1.8, Kiota v1.9 Oct 24, 2023
@baywet baywet removed this from the Kiota v1.9 milestone Nov 28, 2023
@baywet baywet added this to the Kiota v1.10 milestone Nov 28, 2023
@baywet baywet modified the milestones: Kiota v1.10, Kiota v1.11 Jan 11, 2024
@baywet baywet modified the milestones: Kiota v1.11, Kiota v1.12 Jan 30, 2024
@petrhollayms petrhollayms modified the milestones: Kiota v1.12, Backlog Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request generator Issues or improvements relater to generation capabilities. help wanted Issue caused by core project dependency modules or library PHP Python WIP
Projects
Status: In Progress 🚧
Development

Successfully merging a pull request may close this issue.

4 participants