kiota go generator loses properties in schema that contains a oneOf

[mikekistler]

Given a schema that contains properties and a oneOf, the properties of the schema are not present in the generated struct for the schema. An example:

    Widget:
      type: object
      properties:
        kind:
          type: string
        id:
          type: string
        weight:
          type: integer
          format: int32
      required:
        - id
        - kind
        - weight
      oneOf:
        - $ref: '#/components/schemas/Gadget'
        - $ref: '#/components/schemas/WingDing'

The Widget struct generated by Kiota looks like this:

// Widget composed type wrapper for classes Gadget, WingDing
type Widget struct {
    // Stores additional data not described in the OpenAPI description found when deserializing. Can be used for serialization as well.
    additionalData map[string]any
    // Composed type representation for type Gadget
    gadget Gadgetable
    // Serialization hint for the current wrapper.
    SerializationHint *string
    // Composed type representation for type WingDing
    wingDing WingDingable
}

Note that the struct does not contain an id or weight property.

[baywet]

Thanks for reporting this @mikekistler
This is probably not limited to one of but also impacts arrays, all of and any of.
And it's not limited to go.
We should probably determine what we expect to happen in that case?
Should the properties be considered like another one of entry?

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[mikekistler]

@baywet not stale.

[baywet]

@mikekistler Thank you for your patience on this one, can you try to repo on 1.8.1 and let us know whether this is still happening please?

[mikekistler]

It is still happening, though the exact behavior has changed somewhat. With 1.8.1 the Widget schema to converted to the following Go struct:

// Widget composed type wrapper for classes Gadget, WingDing
type Widget struct {
    // Composed type representation for type Gadget
    gadget Gadgetable
    // Composed type representation for type WingDing
    wingDing WingDingable
}

The id and weight fields are still missing.

[baywet]

Note: I recently tested this one again and this is still a problem. The root properties are still missing. This is an area we should switch to pattern matching to exhaust all the scenarios like we did for all of in #4381 and #4668.
What's interesting here is this is equivalent to a allof (schema with properties at root + schema with the two one of), maybe there's something to do in a pre-conversion instead?
@darrelmiller for language that do not support union types what would you want to have projected here? Duplicate the properties in the one of members? (could be messy if those schemas are referenced multiple places)