[java] [question] Query parameters and enums

[andreaTP]

I haven't narrowed down this issue completely, but it seems that enum fields are exposed as strings in queryParameters.
I don't see a huge problem with this decision but I would like to understand if it's deliberate, accidental, or something we want to improve in the longer run.

E.g. here

[baywet]

Thanks for bringing this up. In theory we already have all the bricks we need for this one.
We already know how to project enum types to the code dom, we also have a serialization method for query parameters that are non-trivial (name was changed, etc...)
I think this should be feasible as long as the property is projected to be nullable and as long as the code that handles serialization is updated to call the enum serialization method.
This is something that should be implemented consistently across languages however, and I believe we haven't prioritized that at this point because we don't have enums on the Microsoft Graph API surface being used as query parameters.

[andreaTP]

@baywet thanks for reverting back!

Would you like to dump a few links to significant lines where you expect the code to be touched?
This is going to be helpful to anyone that finds time to jump on it 🙂

[baywet]

Sure,
This is where properties are added to the DOM for query parameters

kiota/src/Kiota.Builder/KiotaBuilder.cs

Line 1692 in 7450b04

Type = GetPrimitiveType(parameter.Schema),

right now it only supports primitive types but calling a simplified version of create model declaration would do the trick (to avoid generating classes)

kiota/src/Kiota.Builder/KiotaBuilder.cs

Line 1289 in 7450b04

private CodeTypeBase CreateModelDeclarations(OpenApiUrlTreeNode currentNode, OpenApiSchema schema, OpenApiOperation? operation, CodeElement parentElement, string suffixForInlineSchema, OpenApiResponse? response = default, string typeNameForInlineSchema = "", bool isRequestBody = false)

Then in the request information the serialization expects annotations for anything that's not trivial, so we'd need to update the annotation to point to the serialization method for the enum
https://github.com/microsoft/kiota-java/blob/812a5a2636d52afc259a792fdf6bdfce9a451118/components/abstractions/src/main/java/com/microsoft/kiota/RequestInformation.java#L102

and update the property generation.

kiota/src/Kiota.Builder/Writers/Java/CodePropertyWriter.cs

Line 24 in 7450b04

writer.WriteLine($"@QueryParameter(name = \"{codeElement.SerializationName}\")");

[andreaTP]

Nice writeup @baywet , appreciated!

[baywet]

Unfortunately this would potentially mean a breaking change for existing users off go and c# and we missed it when we went GA. This will have to wait for v2 at this point.

[baywet]

This is actually a duplicate of #2490 closing