From 2ad912ba9a03611a5fea0c8a8a0aa2175eddc1df Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Fri, 22 Mar 2024 14:42:35 -0400 Subject: [PATCH 1/2] - upgrade codespace configuration following net8 upgrade Signed-off-by: Vincent Biret --- .devcontainer/Dockerfile | 2 +- .devcontainer/devcontainer.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 1d991699f4..6420d7912e 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,6 +1,6 @@ # See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/dotnet/.devcontainer/Dockerfile -ARG VARIANT="7.0-bullseye-slim" +ARG VARIANT="8.0-bookworm-slim" FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT} # [Choice] Node.js version: none, lts/*, 16, 14, 12, 10 diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index f2e49779ab..158465dd6d 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -3,8 +3,8 @@ "build": { "dockerfile": "Dockerfile", "args": { - "VARIANT": "7.0", - "NODE_VERSION": "18" + "VARIANT": "8.0", + "NODE_VERSION": "20" } }, "customizations": { From c8e90fb2675c438ac6470048c1781abdf5510478 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Fri, 22 Mar 2024 14:49:19 -0400 Subject: [PATCH 2/2] - fixes variant name Signed-off-by: Vincent Biret --- .devcontainer/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 6420d7912e..51e30c6552 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,7 +1,7 @@ # See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/dotnet/.devcontainer/Dockerfile ARG VARIANT="8.0-bookworm-slim" -FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT} +FROM mcr.microsoft.com/vscode/devcontainers/dotnet:${VARIANT} # [Choice] Node.js version: none, lts/*, 16, 14, 12, 10 ARG NODE_VERSION="none"