Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure 3XX responses without location header do not throw #1119

Open
baywet opened this issue Mar 21, 2024 · 3 comments
Open

ensure 3XX responses without location header do not throw #1119

baywet opened this issue Mar 21, 2024 · 3 comments
Assignees
Labels
bug Something isn't working goodfirstissue Standard GitHub label used for easy to resolve issues targeting beginner contributors
Milestone

Comments

@baywet
Copy link
Member

baywet commented Mar 21, 2024

follow up to microsoft/kiota#4367
and microsoft/kiota#4190

Implement a unit test with a 304 response, no location header, check the request adapter returns null and doesn't throw.
Most likely this line will need to be adapted.
https://github.com/microsoft/kiota-typescript/blob/985036391e8a9823e363f5c2fde486ae9186ea0a/packages/http/fetch/src/fetchRequestAdapter.ts#L387C9-L387C20

@baywet baywet added bug Something isn't working help wanted labels Mar 21, 2024
@github-project-automation github-project-automation bot moved this to Todo in Kiota Mar 21, 2024
@fey101 fey101 added goodfirstissue Standard GitHub label used for easy to resolve issues targeting beginner contributors and removed Standard GitHub label labels Jun 6, 2024
@harshav1989
Copy link

id like to do this can u pls assign me

@baywet
Copy link
Member Author

baywet commented Jul 16, 2024

Done! Let us know if you have questions.

@harshav1989
Copy link

yup!

@baywet baywet added this to the Kiota-TS-GA milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working goodfirstissue Standard GitHub label used for easy to resolve issues targeting beginner contributors
Projects
Status: New📃
Development

No branches or pull requests

3 participants