Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CancellationToken is required to serialize? #366

Closed
OlavBjorndal opened this issue Sep 2, 2024 · 1 comment · Fixed by #367
Closed

CancellationToken is required to serialize? #366

OlavBjorndal opened this issue Sep 2, 2024 · 1 comment · Fixed by #367
Assignees
Labels
type: bug A broken experience type:regression A bug from previous release WIP

Comments

@OlavBjorndal
Copy link

Hi,

mabye there is something that i haven't been able to grasp yet, and I'm fairly new to kiota.
But during my nuget update of GraphSDK i met this errorMessage:
image

I see the previous version of graphSDK I used had kiota-serialization-json-dotnet 1.3.3, but now with the monorepo im trying to use 1.12.2.

I'm just wondering if I'm doing something wrong, if this is intensionally or just a small bug?

@baywet
Copy link
Member

baywet commented Sep 3, 2024

Hi @OlavBjorndal
Thank you for using kiota and for reaching out.

I think this got lost in the multiple reviews of #311.
I have just authored a pull request to make the parameter optional again and fix a few other alignment issues #367

Let us know if you have any additional comments or questions.

@baywet baywet self-assigned this Sep 3, 2024
@baywet baywet moved this from Needs Triage 🔍 to In Review 💭 in Kiota Sep 3, 2024
@baywet baywet added type: bug A broken experience type:regression A bug from previous release and removed WIP labels Sep 3, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A broken experience type:regression A bug from previous release WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants