Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http - align OTEL http attributes with latest standard #344

Closed
baywet opened this issue Aug 27, 2024 · 0 comments · Fixed by #435
Closed

http - align OTEL http attributes with latest standard #344

baywet opened this issue Aug 27, 2024 · 0 comments · Fixed by #435
Labels
help wanted Standard GitHub label type: bug A broken experience WIP

Comments

@baywet
Copy link
Member

baywet commented Aug 27, 2024

to maintain compatibility with external tooling we should make sure our attribute respect the latest (stable) semantic conventions. When we initially implemented things, the spec was still in draft. The following attributes need to be renamed in the middleware handlers and in the request adapter:
htttp.status_code => http.response.status_code
http.response_content_length => http.response.body.size
http.request_content_length => http.request.body.size
http.flavor => network.protocol.name
http.response_content_type => http.response.header.content-type
http.request_content_type => http.request.header.content-type
http.method => http.request.method
http.host => url.scheme
http.scheme => server.address
http.uri => url.full
http.uri_template => url.uri_template

link to the spec for more information https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/
related microsoftgraph/msgraph-sdk-design#108

@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Aug 27, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Aug 27, 2024
@baywet baywet added type: bug A broken experience help wanted Standard GitHub label labels Aug 27, 2024
@baywet baywet moved this from Todo 📃 to In Review 💭 in Kiota Oct 10, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Standard GitHub label type: bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant