Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published kiota packages depend on DiagnosticSource < 8.0.0 #149

Closed
charlesroddie opened this issue Nov 14, 2023 · 1 comment · Fixed by #150
Closed

Published kiota packages depend on DiagnosticSource < 8.0.0 #149

charlesroddie opened this issue Nov 14, 2023 · 1 comment · Fixed by #150
Assignees
Labels
enhancement New feature or request WIP

Comments

@charlesroddie
Copy link

kiota packages such as Microsoft.Kiota.Abstractions 1.7.1 (published today) require System.Diagnostics.DiagnosticSource (>= 6.0.0 && < 8.0.0).

The explicit failure to work with 8.0.0 creates a lot of problems for packages released together with dotnet 8 which bring in DiagnosticSource 8.0.0. For example we get build failures with Microsoft.Extensions.Http 8.0.0 -> Microsoft.Extensions.Diagnostics 8.0.0 -> Microsoft.Extensions.Diagnostics.Abstractions 8.0.0 -> System.Diagnostics.DiagnosticSource (>= 8.0.0) .

@baywet baywet transferred this issue from microsoft/kiota Nov 14, 2023
@baywet baywet mentioned this issue Nov 14, 2023
@baywet baywet self-assigned this Nov 14, 2023
@baywet baywet added the enhancement New feature or request label Nov 14, 2023
@baywet baywet moved this from Todo to In Progress in Kiota Nov 14, 2023
@baywet
Copy link
Member

baywet commented Nov 14, 2023

Thank you for using kiota and for reaching out.
I just put together #150 to start the process here.
We'll need to cascade the changes. For this to be entirely available, see microsoft/kiota-serialization-json-dotnet#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants