New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS number - decimal should map to float128 in Go #184

Open

baywet opened this issue Oct 8, 2024 · 0 comments

Labels

bug type:breaking-change

Member

baywet commented Oct 8, 2024

See this PR for the mappings across languages MicrosoftDocs/openapi-docs#121

Currently decimal in Go maps to float64, which is too short. It should map to float128 instead. This will be a breaking change and requires:

A new method in ParseNode
A new method in SerializationWriter
Implementations across serialization/parse node
A new entry in the Go Conventions Service (kiota)
Potential new mappings in Go CodeMethodWriter for the serialization and parse node calls.

github-project-automation bot added this to Kiota

github-project-automation bot moved this to Needs Triage 🔍 in Kiota

baywet added bug type:breaking-change labels

baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment