Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payload-generator] Failing to generate for merged selection set #298

Open
alloy opened this issue Apr 21, 2023 · 2 comments
Open

[payload-generator] Failing to generate for merged selection set #298

alloy opened this issue Apr 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@alloy
Copy link
Member

alloy commented Apr 21, 2023

When there are two fragments on the same type, the selection sets should be merged. This isn't happening. It might also be related to the object being inside a list.

Needs a failing test case.

/cc @sjwilczynski

@alloy alloy added the bug Something isn't working label Apr 21, 2023
@sjwilczynski
Copy link
Contributor

Thanks for tagging me, I have it on mt list to add the test case but it's after connect > finishing testing PR in TMP > finishing storybook PR in facade. In case you'd need it earlier for any reason, please ping me :)

@sjwilczynski
Copy link
Contributor

I tried to create a repro, couldn't manage with relay test schema. Copied the whole 1GQL schema inside the repo and ported LPE fragments. Still no repro. I removed the custom resolvers override from TMP and now it works! So turns out there was a change somewhere between 0.10.5 and 0.12.2 which fixed the behavior. IMO we should close the issue, unless you feel strongly about trying to find the exact change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants