Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily Forecast forces lag_periods. Customer has no option to override #77

Open
AKannanMSFT opened this issue Oct 21, 2021 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@AKannanMSFT
Copy link
Contributor

AKannanMSFT commented Oct 21, 2021

When customers submit a daily forecast, no matter what, we force the lag_periods to be a fixed value in multivariate_prep_recipe_2:

lag_periods_r2 <- unique(c(1, 2, 3, 4, 5, 6, 7, 14, 21, 28, 28*2, 28*3, 28*6, 28*9, 28*12, 365, forecast_horizon))

We don't allow for the customer to override this value like we do in multivariate_prep_recipe_1

This is a problem in a setting where the data doesn't have 365 data points. i.e. say we have 300 data points, this line breaks.

@mitokic mitokic self-assigned this Nov 12, 2021
@mitokic mitokic added enhancement New feature or request bug Something isn't working labels Nov 12, 2021
@mitokic mitokic linked a pull request Nov 12, 2021 that will close this issue
@mitokic
Copy link
Collaborator

mitokic commented Nov 12, 2021

Thanks for calling this out Aadharsh.

Now by default R2 recipes are turned off for daily forecasts.

Currently there is a hybrid process going on. Yes there are some default lag values that are created in your code reference above, but later in the function these values are joined with the "lag_periods" object that allows users to adjust it or use the default. So there is some control there. The extra lags are added to ensure we are getting most out of the features the R2 brings compared to R1, mostly around using lags that are less than the forecast horizon.

With that being said there could be cases where an error occurs like your example. I think in most situations this will not happen, since the R2 recipe is turned off by default for daily forecasts. And if a user has specifically tuned on the recipe, I assume they would have a robust historical data set to leverage.

This is an area we could explore more in the future to fix potential errors with small datasets. I think for now we can hold off on this fix until after v0.1 launch.

@mitokic mitokic removed a link to a pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants