Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: picker max suggestions #6818

Closed
wants to merge 2 commits into from

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Aug 21, 2023

📖 Description

While building a picker based ui with larger collections of suggestions I found that I needed to truncate the number of suggestions rendered in the UI "as you type". Makes sense for picker to enables this internally. This change adds a "max-suggestions" attribute to picker as well as showing a "type for more" message when large suggestion sets are truncated.

image

Also fixed an issue where max selection could be exceeded programmatically.

🎫 Issues

ad hoc

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • [] I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@janechu
Copy link
Collaborator

janechu commented Jun 14, 2024

@scomea circling back to this, is it still needed?

@janechu
Copy link
Collaborator

janechu commented Jun 14, 2024

I'm going to close this as we are avoiding features while we reconcile open PRs with #6951.

@janechu janechu closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants