Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fast element export paths with extensions #6815

Merged

Conversation

chrisdholt
Copy link
Member

Pull Request

📖 Description

This PR updates the fast-element export paths to include extensions.

With import maps now providing a standard for package resolution in browsers and other JavaScript runtimes, using the extensionless style can result in bloated import map definitions. Explicit file extensions can avoid this issue by enabling the import map to utilize a packages folder mapping to map multiple subpaths where possible instead of a separate map entry per package subpath export. This also mirrors the requirement of using the full specifier path in relative and absolute import specifiers.

See here for more: https://nodejs.dev/en/api/v18/packages/#extensions-in-subpaths

🎫 Issues

Part of #6809

👩‍💻 Reviewer Notes

Build should pass w/o API changes

@chrisdholt chrisdholt force-pushed the users/chhol/update-fast-element-export-paths-with-extensions branch from 43054b4 to dd4976d Compare August 16, 2023 20:48
@nicholasrice
Copy link
Contributor

Should we update all package's w/ export paths along with fast-element? Seems it would be good to keep everything consistent.

@chrisdholt
Copy link
Member Author

chrisdholt commented Aug 17, 2023

Should we update all package's w/ export paths along with fast-element? Seems it would be good to keep everything consistent.

@nicholasrice yes, I think so but I first wanted to focus on the immediate and "breaking" things...which I see there are some in SSR. I'll do another run to make sure we get all existing...

@chrisdholt chrisdholt merged commit 2dab94c into master Aug 17, 2023
5 checks passed
@chrisdholt chrisdholt deleted the users/chhol/update-fast-element-export-paths-with-extensions branch August 17, 2023 23:10
janechu pushed a commit that referenced this pull request Jun 10, 2024
* update fast-element export paths to include extensions

* Change files

* update react wrapper

* Change files

* Update change/@microsoft-fast-element-7dca0636-ad22-44b9-b9b3-19f7d7fbf6b0.json

* update ssr export paths to include extensions as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants