-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update fast element export paths with extensions #6815
fix: update fast element export paths with extensions #6815
Conversation
43054b4
to
dd4976d
Compare
…hs-with-extensions
change/@microsoft-fast-element-7dca0636-ad22-44b9-b9b3-19f7d7fbf6b0.json
Outdated
Show resolved
Hide resolved
Should we update all package's w/ export paths along with fast-element? Seems it would be good to keep everything consistent. |
@nicholasrice yes, I think so but I first wanted to focus on the immediate and "breaking" things...which I see there are some in SSR. I'll do another run to make sure we get all existing... |
* update fast-element export paths to include extensions * Change files * update react wrapper * Change files * Update change/@microsoft-fast-element-7dca0636-ad22-44b9-b9b3-19f7d7fbf6b0.json * update ssr export paths to include extensions as well
Pull Request
📖 Description
This PR updates the fast-element export paths to include extensions.
See here for more: https://nodejs.dev/en/api/v18/packages/#extensions-in-subpaths
🎫 Issues
Part of #6809
👩💻 Reviewer Notes
Build should pass w/o API changes