From 736081a4bfbca30aa6b8de6802f98907e8d2dc85 Mon Sep 17 00:00:00 2001 From: Fedor Dikarev Date: Tue, 14 May 2024 22:25:23 +0200 Subject: [PATCH 1/4] address warnings: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20 --- .github/workflows/pages.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml index d30f8881..f6ff6d28 100644 --- a/.github/workflows/pages.yml +++ b/.github/workflows/pages.yml @@ -1,4 +1,5 @@ name: pages +de on: workflow_dispatch: @@ -23,7 +24,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "20" cache: "npm" cache-dependency-path: frontend/package-lock.json @@ -62,7 +63,7 @@ jobs: - uses: actions/setup-node@v3 if: github.repository_owner == 'microsoft' with: - node-version: "14" + node-version: "20" - run: npm init -y if: github.repository_owner == 'microsoft' From 9982a543955a43d0b44216bbdf30d046f59382f8 Mon Sep 17 00:00:00 2001 From: Fedor Dikarev Date: Tue, 14 May 2024 22:30:03 +0200 Subject: [PATCH 2/4] add current branch for manual testing workflow --- .github/workflows/pages.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml index f6ff6d28..c42cc288 100644 --- a/.github/workflows/pages.yml +++ b/.github/workflows/pages.yml @@ -9,6 +9,7 @@ on: pull_request: branches: - main + - fix/github-actions-node-16-to-node-20 permissions: packages: write contents: write From a1c8e31a96275589f30e4aac260c93670ab75eee Mon Sep 17 00:00:00 2001 From: Fedor Dikarev Date: Tue, 14 May 2024 22:31:10 +0200 Subject: [PATCH 3/4] fix --- .github/workflows/pages.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml index c42cc288..069eb94a 100644 --- a/.github/workflows/pages.yml +++ b/.github/workflows/pages.yml @@ -1,5 +1,4 @@ name: pages -de on: workflow_dispatch: From d887e4fec313182cde0ae4fdcefb8cbdc15e3b43 Mon Sep 17 00:00:00 2001 From: Fedor Dikarev Date: Tue, 14 May 2024 22:37:17 +0200 Subject: [PATCH 4/4] fix warnings base option should start|end with a slash. --- .github/workflows/pages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml index 069eb94a..b12ab34c 100644 --- a/.github/workflows/pages.yml +++ b/.github/workflows/pages.yml @@ -33,7 +33,7 @@ jobs: working-directory: frontend - name: Build Static Web App - run: npm run build -- --base=$BASE_URL + run: npm run build -- --base=/$BASE_URL/ env: BASE_URL: ${{ github.event.repository.name }} VITE_FACE_API_KEY: ${{ secrets.VITE_FACE_API_KEY }}