Use RawInput for ContinueAsNew

microsoft · Oct 10, 2023 · 226d595 · 226d595
1 parent 273db1a
commit 226d595
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## v1.0.5
+
+### Microsoft.DurableTask.Worker
+
+- Fix re-encoding of events when using `TaskOrchestrationContext.ContinueAsNew(preserveUnprocessedEvents: true)`
+
 ## v1.0.4
 
 ### Microsoft.DurableTask.Worker

diff --git a/src/Abstractions/Abstractions.csproj b/src/Abstractions/Abstractions.csproj
@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.DurableTask.Core" Version="2.11.1" />
+    <PackageReference Include="Microsoft.Azure.DurableTask.Core" Version="2.15.0" />
     <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.0" />

diff --git a/src/Client/Core/RELEASENOTES.md b/src/Client/Core/RELEASENOTES.md
diff --git a/src/Client/Grpc/RELEASENOTES.md b/src/Client/Grpc/RELEASENOTES.md
diff --git a/src/Client/OrchestrationServiceClientShim/RELEASENOTES.md b/src/Client/OrchestrationServiceClientShim/RELEASENOTES.md
diff --git a/src/Worker/Core/RELEASENOTES.md b/src/Worker/Core/RELEASENOTES.md
@@ -1 +1 @@
-- Fix handling of concurrent external events with the same name (https://github.com/microsoft/durabletask-dotnet/pull/194)
+- Fix re-encoding of events when using `TaskOrchestrationContext.ContinueAsNew(preserveUnprocessedEvents: true)`
diff --git a/src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs b/src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs
@@ -5,6 +5,7 @@
 using System.Security.Cryptography;
 using System.Text;
 using DurableTask.Core;
+using DurableTask.Core.Serializing.Internal;
 using Microsoft.Extensions.Logging;
 
 namespace Microsoft.DurableTask.Worker.Shims;
@@ -240,7 +241,9 @@ public override void ContinueAsNew(object? newInput = null, bool preserveUnproce
             OrchestrationInstance instance = new() { InstanceId = this.InstanceId };
             foreach ((string eventName, string eventPayload) in this.externalEventBuffer.TakeAll())
             {
-                this.innerContext.SendEvent(instance, eventName, eventPayload);
+#pragma warning disable CS0618 // Type or member is obsolete -- 'internal' usage.
+                this.innerContext.SendEvent(instance, eventName, new RawInput(eventPayload));
+#pragma warning restore CS0618 // Type or member is obsolete
             }
         }
     }

diff --git a/src/Worker/Grpc/RELEASENOTES.md b/src/Worker/Grpc/RELEASENOTES.md
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		- Fix handling of concurrent external events with the same name (https://github.com/microsoft/durabletask-dotnet/pull/194)
		- Fix re-encoding of events when using `TaskOrchestrationContext.ContinueAsNew(preserveUnprocessedEvents: true)`