New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `U` macro definition from public headers #1805

Open

aminya opened this issue Oct 1, 2024 · 0 comments

aminya commented Oct 1, 2024

Cpprest does some questionable macro definitions here.
microsoft/cpprestsdk@411a109/Release/include/cpprest/details/basic_types.h#L87

The U Macro overrides the U typename in fmt causing fmt not to work. This definition is like a time-bomb waiting to cause problems anytime.

  template <typename T, typename U = format_as_t<T>,
            FMT_ENABLE_IF(std::is_arithmetic<U>::value)>
  FMT_MAP_API auto map(const T& val) -> decltype(FMT_DECLTYPE_THIS map(U())) {
    return map(format_as(val));
  }

Related fmtlib/fmt#4180

Can you remove this macro?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment