Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced verbose logging causes increased runtime #1117

Open
bjowes opened this issue Jan 5, 2023 · 0 comments
Open

Forced verbose logging causes increased runtime #1117

bjowes opened this issue Jan 5, 2023 · 0 comments

Comments

@bjowes
Copy link

bjowes commented Jan 5, 2023

We are using the task IISWebAppMgmt@3 to deploy our web apps to IIS. The runtime of this task is rather long (about 40 seconds, occasionally much longer) given the actions it actually performs.

When investigating runtime for our other tasks I found that the amount of logging from Remote PowerShell execution has a significant impact on runtime. We had one task where the runtime was reduced from 40 seconds to 9 seconds simply by disabling verbose logging. After this find I looked into if I could somehow disable verbose logging for the IISWebAppMgmt@3 task. However, it seems that verbose logging is hard coded into a utility method used by the task, from this specific line:

Given how it is coded, I don't think it is possible to disable the verbose logging. Please add this possibility!
In my view a better default would be to not output verbose logging, but instead provide a possibility to enable it. Verbose logging could for instance be controlled by:

  • a new parameter to the task
  • the "System.Debug" environment variable
  • some other environment variable
    If it is decided to keep it enabled by default, it would still be a great improvement if a possibility to disable it was added.

I have not investigated how many tasks are affected by this, but I assume that IISWebAppMgmt@3 is just one of many that use the relevant script for remote PowerShell execution. Hence, fixing this has a great potential in improving deployment runtime for a huge amount of Azure DevOps users.

If the above makes sense, I would be happy to provide a PR to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant