-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
az containerapp dapr enable --dapr-http-max-request-size 32 fails to increase max-request size. #411
Comments
@dale-personal When you view the container app json in the portal, can you please change the api version using the drop-down to |
Ok, i do see the expected values when i change the API version: I've done a little more digging and I believe the setting is working as expected for "normal" service calls. I believe the bug is in the ActorProxy. When calling an actor proxy method that returns more that 4 MB of payload, I get the error below. I have set httpMaxRequestSize to 32 on the actor service, and as seen in the stack trace, it uses http, not grpc. 2022-09-23T15:51:35.732224614Z fail: Microsoft.AspNetCore.Server.Kestrel[13] |
This change is still rolling out - thanks for your patience. We will investigate |
Hi @dale-personal , this looks like an issue in dapr actor. Could you also file a bug to dapr? https://github.com/dapr/dapr/issues |
This appears to be a DotNet SDK issue. I opened this tracking issue dapr/dotnet-sdk#978 This issue should not exist in the Python SDK (though Python currently does not use gRPC for actors while the DotNet SDK does). |
Please note that the receiving application (the actor host) must support receiving messages of the desired size. Some frameworks do not support such large messages by default and additional configuration may be required. |
I was not able to reproduce the issue with the dotnet-sdk. I was able to successfully send a >4MB payload through a remoting client.
and I used the following code to measure the total payload size:
@dale-personal Do you mind sharing how did you set httpMaxRequestSize to 32 on the actor service ? |
Above in the steps to reproduce:
There is no way to set this specifically for the actor service, just the dapr runtime as far as i know. so the assumption is executing this commend set the max request size for the actor service as well (and it does work using dapr locally outside of the container environment) |
@dale-personal Would you be able to answer a few more questions if possible so we can troubleshoot what's going on.
|
|
Closing this issue due to it being inactive. If it still exists please reopen a new issue and point to this to preserve history. |
This issue is a: (mark with an x)
Issue description
Following the documentation found here:
https://learn.microsoft.com/en-us/cli/azure/containerapp/dapr?view=azure-cli-latest#az-containerapp-dapr-enable
The parameter to increase max request size does not increase the max request size.
Steps to reproduce
2022-09-21T12:26:38.938415931Z ---> System.IO.IOException: The response ended prematurely.
Expected behavior [What you expected to happen.]
The container app has dapr enabled with the max request size increased.
When i run this command the output seems to indicate success:
{
"appId": "api",
"appPort": 80,
"appProtocol": "http",
"enableApiLogging": false,
"enabled": true,
"httpMaxRequestSize": 32,
"logLevel": "info"
}
Actual behavior [What actually happened.]
dapr is enabled, but the max request size is not increased.
When i look at the JSON for the container app overview in the portal, I only see:
"dapr": {
"enabled": true,
"appId": "api",
"appProtocol": "http",
"appPort": 80
}
The text was updated successfully, but these errors were encountered: