Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion]: Add password length constraint for the build machine #831

Open
1 task done
drcircuit opened this issue Apr 2, 2024 · 2 comments
Open
1 task done

[Suggestion]: Add password length constraint for the build machine #831

drcircuit opened this issue Apr 2, 2024 · 2 comments

Comments

@drcircuit
Copy link

Which Hack?

001-IntroToKubernetes

Suggestion

Add the minLength property of 12 for the admin password user input. If a shorter one is provided, the previous version would still deploy the machine, but the password would not be configured, I also added the complexity requirements in the description to make the user aware of these requirements, you can still choose a password that doesn't match the criteria, then the machine will be created but no password will be configured.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@drcircuit
Copy link
Author

Added a pr for this.

@drcircuit
Copy link
Author

Phone was too eager

@drcircuit drcircuit reopened this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drcircuit