Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mouse Without Borders] - refactoring "Common" classes #35155

Open
mikeclayton opened this issue Sep 30, 2024 · 5 comments
Open

[Mouse Without Borders] - refactoring "Common" classes #35155

mikeclayton opened this issue Sep 30, 2024 · 5 comments
Labels
Idea-Enhancement New feature or request on an existing product Product-Mouse Without Borders Refers to the Mouse Without Borders module Status-In progress This issue or work-item is under development

Comments

@mikeclayton
Copy link
Contributor

Description of the new feature / enhancement

As a precursor to #34126 (Integrate Mouse Jump with Mouse Without Borders) I've spoken with @crutkas and @ethanfangg about doing some mechanical refactoring to break the large "Common" class into multiple smaller classes as general maintenance / housekeeping work.

Each "Common.*.cs" partial file will be turned into a separate static class so as to reduce the scope of the private members inside them and make it easier / safer to perform other changes (e.g. integration with Mouse Jump) at a later date.

Changes to each "Common.*.cs" file will be submitted as a separate PR.

Scenario when this would be used?

No change in functionality - this is a refactoring / maintenance change designed to make some future work easier / safer to implement.

Supporting information

No response

@mikeclayton mikeclayton added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 30, 2024
@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Product-Mouse Without Borders Refers to the Mouse Without Borders module and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 1, 2024
@crutkas
Copy link
Member

crutkas commented Oct 1, 2024

Make it so

mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Oct 20, 2024
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Oct 20, 2024
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Oct 20, 2024
@crutkas
Copy link
Member

crutkas commented Oct 30, 2024

@mikeclayton isn't this #35156 or is there more

@crutkas crutkas added the Status-In progress This issue or work-item is under development label Oct 30, 2024
@mikeclayton
Copy link
Contributor Author

mikeclayton commented Oct 30, 2024

@crutkas - There's more PRs to come - there's about a dozen "Common.*.cs" classes and we talked about moving cautiously and doing one file at a time so as not to break anything.

I've been trying to get the Mouse Jump style work over the line in #35521 - once that's done I can spend a bit more time on Mouse Without Borders (I've got a second refactor lined up but I've not had time to go through the regression tests yet)...

@fr1g
Copy link

fr1g commented Nov 11, 2024

What's now? is #35858 related to this?

@mikeclayton
Copy link
Contributor Author

What's now? is #35858 related to this?

This ticket is unrelated to your feature request in #35858.

mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-Mouse Without Borders Refers to the Mouse Without Borders module Status-In progress This issue or work-item is under development
Projects
None yet
Development

No branches or pull requests

3 participants