Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monaco] Use syntax highlighting for .srt #35152

Open
PesBandi opened this issue Sep 30, 2024 · 2 comments
Open

[Monaco] Use syntax highlighting for .srt #35152

PesBandi opened this issue Sep 30, 2024 · 2 comments
Labels
Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development

Comments

@PesBandi
Copy link
Contributor

Description of the new feature / enhancement

Use Monaco Monarch for syntax highlighting in SubRip files.

Scenario when this would be used?

Previewing srt files

Supporting information

No response

@PesBandi PesBandi added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 30, 2024
@PesBandi PesBandi changed the title [Monaco] Improve .srt definition [Monaco] Use syntax highlighting for .srt Oct 28, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Oct 28, 2024

@PesBandi
Go for it.

Currently we support.srt as plain text. So the issue here is about colorize based on a hilighter definition.

@htcfreek htcfreek added Idea-Enhancement New feature or request on an existing product Status-In progress This issue or work-item is under development Product-File Explorer Power Toys that touch explorer like Preview Pane Product-Peek Refers to Peek Powertoys and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 28, 2024
@PesBandi
Copy link
Contributor Author

Hi @htcfreek, thanks for the response.
I've opened a pull request, could you please take a look? I'd appreciate some feedback on the Monarch definition (it's described in the PR's details), thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development
Projects
None yet
Development

No branches or pull requests

2 participants