Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageResizer: Add Convert to JPG #3287

Closed
Mr-Pingu opened this issue May 20, 2020 · 14 comments
Closed

ImageResizer: Add Convert to JPG #3287

Mr-Pingu opened this issue May 20, 2020 · 14 comments
Labels
Idea-Enhancement New feature or request on an existing product Product-Image Resizer Things regarding image resizing module

Comments

@Mr-Pingu
Copy link

Mr-Pingu commented May 20, 2020

Summary of the new feature/enhancement

Would like to convert PNG to JPG as well.
I am running a webshop and many of the pictures are delivered from vendors in PNG format. Which are bigger in size than JPG for normal photos

Wish

Would like to not only resize but also convert to JPG if possible.

Proposed solution

Make checkbox: 'convert aswell'

@Mr-Pingu Mr-Pingu changed the title ImageResizer ImageResizer: Add Convert to JPG May 20, 2020
@crutkas crutkas added Product-Image Resizer Things regarding image resizing module Idea-Enhancement New feature or request on an existing product labels May 22, 2020
@crutkas crutkas added this to the Suggested Enhancements milestone May 22, 2020
@crutkas
Copy link
Member

crutkas commented May 22, 2020

@bricelam thoughts?

@Jay-o-Way
Copy link
Collaborator

If you're gonna add possibility for one filetype conversion, then you better add all of them, because you know in advance people will ask for them.

@bricelam
Copy link
Contributor

@crutkas Years ago, I imagined crating a separate utility (Image Converter?) to do this. I'm a firm believer in the single responsibility principle. 😉

@Mr-Pingu
Copy link
Author

@crutkas Years ago, I imagined crating a separate utility (Image Converter?) to do this. I'm a firm believer in the single responsibility principle. 😉

Honestly, this seems a bit taken too strict. Don't get me wrong, don't want to pick a fight but just an healthy discussion.

Idea of this powertoy is to quickly resize pictures to fit for quick use, isn't it? Atleast that's to me it's strength.
For advanced / batch resizing there many more programs that do a better job, but for a quick resize to use it on the web it's perfect. But take for example a TIFF file. Why would someone resize a TIFF file? I mean what's the point of resizing a quality-focused (over compression / storage) encoding and ending up with a big file anyway but yeah reduced the resolution. I don't see many practical usecases for this but that might be me who's shortsighted?

To me you could easily add this as an option to a profile, so you could have for example have two profiles for eg Medium:
Medium - Force JPG-encoding
Medium - Keep source encoding

This way it doesn't defeat the core purpose / identity of the utility but still give the users the option to force a format if they want.

Let me put it this way: What would you find the best way to resize any give photo for quick use on the web. How would that single purpose utility look like?

I can understand your point of you from a technical view. Technically, you are right and there are 2 repsonsibilities here. 1 Resizing, 1 converting. But practically these goes often together.

@bricelam
Copy link
Contributor

Note, I’m just giving my two cents based on my experience of maintaining the utility for the past twelve years. The Power Toys team will ultimately decide how to evolve the tool going forward.

There are plenty of more powerful utilities out there that can do a lot more. I always strived to keep Image Resizer simple—the UI could quickly get overwhelmed if more features are introduced.

@crutkas
Copy link
Member

crutkas commented Jun 18, 2020

I agree with @bricelam. We aren't aiming to be the end all here. We also get into the world where you can select multiple file types at once then you're dealing with different permutations. IMO, there are tools far better and converting and you'll get better results.

You also start getting into quality issues. JPG to PNG, JPG to GIF, GIF to JPG. All these have a bunch of options for how the image quality will be.

I just can't see us doing this as the tool then starts becoming very heavy

@SvenBudak
Copy link

This tool should really allow to convert to other formats...

@torchsmith
Copy link

At least make an additional powertoy for image conversion. Would be extremely useful to power users.

@Bartmax
Copy link

Bartmax commented Jul 8, 2023

convert images from png to jpg is the most common optimization size reduction task, even more common that resize, so I believe that one and simple option should be in a "resize" tool from mpov.
It's not about having all, it's about having the most common file reducing size strategy.

@ahydronous
Copy link

@crutkas

I assume the Powertools team has access to Windows telemetry.
Could just check which image types are most common and only add those.

Seems to me that adding conversion between .jpg, .png, .webp, .bmp, .heic, .avif (future proofing) and maybe .gif would satisfy the overwhelming majority of users.
Power+ users that would need support for more exotic formats probably would be (begrudgingly) understanding about having to download a dedicated tool.

@arya-coding
Copy link

A right click on an image and within the menu you could convert images. Conversion on .jpg, .png, .webp, .heic would already cover most use cases

@neuromask
Copy link

Especially needed for heic to jpg format, since not all services still support HEIC formats.

@tazztone
Copy link

wanted to resize+convert a TIFF to jpg. :(

@StefanoTesla
Copy link

Helloooooo this should an amazing feature!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-Image Resizer Things regarding image resizing module
Projects
None yet
Development

No branches or pull requests